Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

advertise SAFELIST #2196

Merged
merged 1 commit into from
Oct 6, 2024
Merged

advertise SAFELIST #2196

merged 1 commit into from
Oct 6, 2024

Conversation

slingamn
Copy link
Member

@slingamn slingamn commented Oct 6, 2024

https://modern.ircdocs.horse/#safelist-parameter

LIST is implemented via blocking (*ResponseBuffer).Send, so it can never exceed the sendq limit.

@delthas points out that this token is not especially useful to clients:

  1. If it is not advertised, it probably means that the server is not aware of it, not that LIST is unsafe
  2. It's not really actionable because the only thing the client can do is to not send LIST at all, which seems unreasonable

LIST is implemented via blocking (*ResponseBuffer).Send, so it can never
exceed the sendq limit.
@slingamn slingamn merged commit 726d997 into ergochat:master Oct 6, 2024
1 check passed
@slingamn slingamn deleted the safelist branch October 7, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants