Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project #13

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update project #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a25ae5
Updated the build
laughedelic Oct 23, 2017
4688f67
Fixed compilation error related to the definition of AnyDataSet
laughedelic Oct 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
name := "projects"
organization := "era7bio"
description := "projects project"

bucketSuffix := "era7.com"

crossScalaVersions := Seq("2.11.11", "2.12.3")
scalaVersion := crossScalaVersions.value.last

libraryDependencies ++= Seq(
"ohnosequences" %% "cosas" % "0.8.0",
"ohnosequences" %% "aws-scala-tools" % "0.18.1",
"ohnosequences" %% "datasets" % "0.4.1"
"ohnosequences" %% "cosas" % "0.10.1",
"ohnosequences" %% "aws-scala-tools" % "0.20.0",
"ohnosequences" %% "datasets" % "0.5.2"
)

// NOTE should be reestablished
wartremoverErrors in (Test, compile) := Seq()
wartremoverErrors in (Compile, compile) := Seq()
// wartremoverErrors in (Test, compile) := Seq()
// wartremoverErrors in (Compile, compile) := Seq()
2 changes: 1 addition & 1 deletion project/build.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=0.13.13
sbt.version = 1.0.2
6 changes: 3 additions & 3 deletions project/plugins.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
resolvers ++= Seq(
"Era7 maven releases" at "https://s3-eu-west-1.amazonaws.com/releases.era7.com",
"repo.jenkins-ci.org" at "https://repo.jenkins-ci.org/public"
"repo.jenkins-ci.org" at "https://repo.jenkins-ci.org/public",
Resolver.jcenterRepo
)

addSbtPlugin("ohnosequences" % "nice-sbt-settings" % "0.8.0-RC5")
addSbtPlugin("ohnosequences" % "nice-sbt-settings" % "0.9.0")
4 changes: 3 additions & 1 deletion src/main/scala/projects.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,9 @@ trait AnyTask extends AnyType {
type Input <: AnyDataSet
val input: Input

type Output <: AnyDataSet
// FIXME: this is supposed to be the same:
// type Output <: AnyDataSet // = AnyRecordType.Of[AnyData]
type Output <: AnyRecordType { type Keys <: AnyProductType { type Types <: AnyKList { type Bound <: AnyData } } }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why it doesn't compile with AnyDataSet, which is AnyRecordType.Of[AnyData], which is supposed to be the same as the last line (which makes it compile):

case object AnyRecordType {
  type Of[+B <: AnyType] = AnyRecordType { type Keys <: AnyProductType.Of[B] }
}
case object AnyProductType {
  type Of[+B <: AnyType] = AnyProductType { type Types <: AnyKList.Of[B] }
}
case object AnyKList {
  type Of[+B] = AnyKList { type Bound <: B }
}

@eparejatobes any clue?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of issues with inference and aliasing. A sample:

val output: Output

// NOTE in a future better world we could use this
Expand Down