Fix summary.pandas frame time index type error #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreas-el
reviewed
Dec 3, 2024
andreas-el
reviewed
Dec 3, 2024
andreas-el
previously requested changes
Dec 3, 2024
eivindjahren
reviewed
Dec 3, 2024
The test_pandas2_compatibility_dataframe_index test scenario is covered by test_summary_to_pandas_frame
eivindjahren
approved these changes
Dec 4, 2024
eivindjahren
dismissed
andreas-el’s stale review
Dismissing it as I just approved it and we need to get the bugfix out.
eivindjahren
deleted the
fix-summary.pandas_frame-time_index-TypeError
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #1028
Approach
Add test, solve issue