Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Clean up no-results page #420

Merged
merged 2 commits into from
Jan 9, 2025
Merged

fix: Clean up no-results page #420

merged 2 commits into from
Jan 9, 2025

Conversation

o-jorgensen
Copy link
Contributor

This PR will add some changes to the "No results" page:

  • Change variogram/object links from <a href> to <Link to> to avoid page refresh.
  • Remove the <InfoPageComponent> wrapper to simplify styling
  • Decrease Halloween factor (remove cobweb box image)

Closes #419

@o-jorgensen o-jorgensen self-assigned this Dec 27, 2024
@o-jorgensen o-jorgensen requested a review from mheggelund January 9, 2025 07:51
mheggelund
mheggelund approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@mheggelund mheggelund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

src/features/Results/NoResults/NoResults.tsx Outdated Show resolved Hide resolved
@mheggelund mheggelund merged commit 0dcea91 into main Jan 9, 2025
4 checks passed
@mheggelund mheggelund deleted the fix/no-results-page branch January 9, 2025 07:55
@pepm-ci pepm-ci bot mentioned this pull request Jan 2, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mheggelund mheggelund mheggelund approved these changes

Assignees

@o-jorgensen o-jorgensen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up no-results page
2 participants
@o-jorgensen @mheggelund