Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/disable action based on role #349

Merged
merged 5 commits into from
Oct 24, 2024
Merged

Conversation

thomaslf97
Copy link
Contributor

No description provided.

@thomaslf97 thomaslf97 linked an issue Oct 21, 2024 that may be closed by this pull request
@thomaslf97 thomaslf97 requested a review from Sinrefvol October 21, 2024 11:09
thomaslf97 and others added 2 commits October 21, 2024 14:20
Co-authored-by: Mathias Oppedal Heggelund <[email protected]>
Co-authored-by: Mathias Oppedal Heggelund <[email protected]>
@mheggelund
Copy link
Collaborator

mheggelund commented Oct 21, 2024

Seems to work as intended. Came accross one case where the createdBy was empty, and then had full access to the model. It might be an old model not having all the metadata we have today?

image

Copy link
Collaborator

@mheggelund mheggelund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, seems to work fine!

Left some small comments and thoughts.

@mheggelund
Copy link
Collaborator

mheggelund commented Oct 21, 2024

When buttons and other functions just are disabled in the UI, we might want/need to add some information to the user why?

At least disable the tooltips that exists that do not longer apply? E.g. on the delete in the picture
image

@thomaslf97 thomaslf97 merged commit ba5ac6d into main Oct 24, 2024
4 checks passed
@thomaslf97 thomaslf97 deleted the feat/disable-action-based-on-role branch October 24, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement consistent role based access on frontend and backend
2 participants