Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor model page styles and micro copy #324

Merged
merged 11 commits into from
Oct 3, 2024
Merged

chore: refactor model page styles and micro copy #324

merged 11 commits into from
Oct 3, 2024

Conversation

o-jorgensen
Copy link
Contributor

@o-jorgensen o-jorgensen commented Sep 19, 2024 •
edited
Loading

TL;DR;

  • Refactor the model page and upload page, including some dialogs
  • Adjust micro copy (error messages, form labels, etc.)
  • Align spacing and colours with EDS tokens.
  • Replace custom typography with EDS typography
  • Replace custom form validation banners with EDS validation helpers
  • Remove redundant markup elements

image

@o-jorgensen o-jorgensen self-assigned this Sep 19, 2024
@o-jorgensen o-jorgensen marked this pull request as ready for review September 24, 2024 06:42
mheggelund
mheggelund approved these changes Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@mheggelund mheggelund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good. Made some small fixes.

src/features/ModelView/ModelMetadataView/ModelMetadataView.tsx Outdated Show resolved Hide resolved
@mheggelund mheggelund merged commit 2631e27 into main Oct 3, 2024
4 checks passed
@mheggelund mheggelund deleted the chore/refactor-model-page-styles-and-microcopy branch October 3, 2024 06:44
@pepm-ci pepm-ci bot mentioned this pull request Sep 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mheggelund mheggelund mheggelund approved these changes

Assignees

@o-jorgensen o-jorgensen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@o-jorgensen @mheggelund