Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to pyproject toml #262

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Migrate to pyproject toml #262

merged 3 commits into from
Sep 12, 2024

Conversation

larsevj
Copy link
Contributor

@larsevj larsevj commented Sep 10, 2024

No description provided.

@larsevj larsevj force-pushed the migrate_to_pyproject_toml branch 4 times, most recently from fc03b62 to 96a3bd2 Compare September 10, 2024 16:43
@larsevj
Copy link
Contributor Author

larsevj commented Sep 10, 2024

Worth noting that it does not look like pyproject.toml supports long_description , so not sure how easy it is to get the pypi description to include both README.rst and HISTORY.rst.

@larsevj larsevj marked this pull request as ready for review September 12, 2024 07:28
@larsevj larsevj requested a review from berland September 12, 2024 07:30
@berland
Copy link
Collaborator

berland commented Sep 12, 2024

squash commit 3 and 4 (the ruff fixup)?

@larsevj larsevj force-pushed the migrate_to_pyproject_toml branch from e5e5980 to c72af24 Compare September 12, 2024 08:14
@larsevj
Copy link
Contributor Author

larsevj commented Sep 12, 2024 •
edited
Loading

squash commit 3 and 4 (the ruff fixup)?

Done. Commit 5 was also part of the ruff fixes.

@larsevj larsevj force-pushed the migrate_to_pyproject_toml branch from c72af24 to ab3f7cf Compare September 12, 2024 08:28
berland
berland approved these changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@berland berland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✈️

@larsevj larsevj force-pushed the migrate_to_pyproject_toml branch from ab3f7cf to acf6959 Compare September 12, 2024 08:44
@larsevj larsevj merged commit 0b2e557 into master Sep 12, 2024
8 checks passed
@larsevj larsevj deleted the migrate_to_pyproject_toml branch September 12, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berland berland berland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@larsevj @berland