TEST PR: Invert default schema URLs #973
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mferrera
force-pushed
the
invert-schema-url-staging-ok
branch
3 times, most recently
from
0444283 to
33f1560
Compare
This creates a distinct directory that we will serve from the Radix endpoint. The script that modifies the id when the Docker image starts is still present, but modified. It will be removed when the schemas URLs are set from the relevant branch (main for dev, staging for prod).
This reverts the docker `chown` back to the workdir without specifying the schemas dir directly, which was incorrect to do.
This implements some additional linting rules and prepares a few others. It also adds the `--cov --cov-report term-missing` coverage report to be emitted at the end of test runs, which may be noisier but still useful to see. The test runs install the package with `-e` now so that the code lines missing test coverage are visible.
This creates a pattern for defining schema versions, filenames, and paths. These can then be used throughout the code without being hardcoded strings. The dev and prod URLs are also now present in the code. In the main branch the `$id` URLs now point to the dev enviroment, as this environment tracks main anyway. The idea is that these URLs switching to the production ones will be a step during the promotion to the staging environment. Currently this is done "secretly" with a shell script but as the number of schemas grows, I think it makes more sense to have this be explicit.
This will cause the schemas to overwrite with an updated $id field, but only if nothing else has changed. It is also tested in GitHub Actions.
This restructures how these classes are formed and where they live. It was confusing to locate them with the model when they are really just tweaks to the model for us when exporting. This refactor tries to bring some clarity to that relationship.
This change moves the dev and prod url changes and checks to the dev release side. It is checked in the 'staging' branch so that it happens explicitly.
mferrera
force-pushed
the
invert-schema-url-staging-ok
branch
from
33f1560 to
aa93b57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shows what happens when the schemas are properly up-to-date