FIX: Invert default schema URLs #971
Conversation
mferrera
force-pushed
the
invert-schema-url
branch
2 times, most recently
from
1751d3e to
762e5ac
Compare
mferrera
force-pushed
the
invert-schema-url
branch
4 times, most recently
from
5b21277 to
ad968ea
Compare
mferrera
force-pushed
the
invert-schema-url
branch
5 times, most recently
from
0a3a6f0 to
c939dc6
Compare
| if [[ "${{ github.event.pull_request.base.ref }}" == "staging" ]]; then | ||
| pytest -n auto -v --cov --cov-report term-missing --prod |
There was a problem hiding this comment.
Both pytest and update-schemas take a --prod flag now. Both ensure the DEV_SCHEMAS environment variable is unset. This causes the default case to happen: schemas and metadata are produced with the production url.
| "pytest", | ||
| "pytest-xdist", |
There was a problem hiding this comment.
Sort + not sure why this dependency was never added to parallelize tests
| if os.environ.get("DEV_SCHEMA", False): | ||
| return DEV_URL | ||
| return PROD_URL |
There was a problem hiding this comment.
We won't be able to produce metadata with the $schema = radix dev in Komodo bleeding without exploring some other option. I guess this is OK but not ideal. Could check for KOMODO_BLEEDING explicitly, but I don't really like that
| def pytest_addoption(parser): | ||
| parser.addoption( | ||
| "--prod", action="store_true", help="Use schemas/metadata with production URLs." | ||
| ) |
There was a problem hiding this comment.
Makes pytest aware of our custom pytest --prod command, configured below. But also set at the top of this file because pytest, and some tests, do funky things with environment variables. Since the models in dataio look for this environment variable it is safest to ensure it's set before they are imported, but are still set by the pytest config anyway
| # Ensures URLs will differ based on above | ||
| import fmu.dataio._models as models |
There was a problem hiding this comment.
Lazy import to ensure the models receive the DEV_SCHEMA env var we want them to
mferrera
force-pushed
the
invert-schema-url
branch
from
c939dc6 to
1f119f5
Compare
Resolves #968