Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: Define schema inside FmuResults model #970

Merged
merged 1 commit into from
Jan 14, 2025
Merged

MAINT: Define schema inside FmuResults model #970

merged 1 commit into from
Jan 14, 2025

Conversation

tnatt
Copy link
Collaborator

@tnatt tnatt commented Jan 14, 2025

Closes #969

Change so that the $schema field (the schema url) is added to the MetadataBase used in the FmuResults model, instead of directly into the ObjectMatadataExport and CaseMetadataExport.

This change will add the definition of this field into the schema.

@tnatt tnatt requested a review from mferrera January 14, 2025 08:19
mferrera
mferrera approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@mferrera mferrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 One step closer to consistency

@tnatt tnatt merged commit 3edc1dc into equinor:main Jan 14, 2025
16 checks passed
mferrera pushed a commit to mferrera/fmu-dataio that referenced this pull request Jan 14, 2025
@tnatt @mferrera
MAINT: Define schema inside FmuResults model (equinor#970)
7136a4d
mferrera pushed a commit to mferrera/fmu-dataio that referenced this pull request Jan 14, 2025
@tnatt @mferrera
MAINT: Define schema inside FmuResults model (equinor#970)
3820f82
mferrera pushed a commit to mferrera/fmu-dataio that referenced this pull request Jan 14, 2025
@tnatt @mferrera
MAINT: Define schema inside FmuResults model (equinor#970)
836ce7c
mferrera pushed a commit to mferrera/fmu-dataio that referenced this pull request Jan 14, 2025
@tnatt @mferrera
MAINT: Define schema inside FmuResults model (equinor#970)
4ebbf3c
mferrera pushed a commit to mferrera/fmu-dataio that referenced this pull request Jan 14, 2025
@tnatt @mferrera
MAINT: Define schema inside FmuResults model (equinor#970)
c76e8e5
mferrera pushed a commit to mferrera/fmu-dataio that referenced this pull request Jan 14, 2025
@tnatt @mferrera
MAINT: Define schema inside FmuResults model (equinor#970)
9d4d031
mferrera pushed a commit to mferrera/fmu-dataio that referenced this pull request Jan 14, 2025
@tnatt @mferrera
MAINT: Define schema inside FmuResults model (equinor#970)
c1e8808
slangeveld pushed a commit to slangeveld/fmu-dataio that referenced this pull request Jan 22, 2025
@tnatt @slangeveld
MAINT: Define schema inside FmuResults model (equinor#970)
a98b7d8
slangeveld pushed a commit that referenced this pull request Jan 22, 2025
@tnatt @slangeveld
MAINT: Define schema inside FmuResults model (#970)
533b4e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mferrera mferrera mferrera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Define schema field inside the FmuResults model
2 participants
@tnatt @mferrera