Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Create enum for tracklog event type #753

Merged
merged 1 commit into from
Aug 7, 2024
Merged

ENH: Create enum for tracklog event type #753

merged 1 commit into from
Aug 7, 2024

Conversation

slangeveld
Copy link
Contributor

Resolves first task in #662

Create an enum TracelogEventTypes for the three valid event types of the TracklogEvent module:

  • created
  • updated
  • or merged

and use that as the type for the field event.

@slangeveld slangeveld requested a review from mferrera August 6, 2024 13:53
mferrera
mferrera approved these changes Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@mferrera mferrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@slangeveld slangeveld merged commit 768ee3a into equinor:main Aug 7, 2024
13 checks passed
@slangeveld slangeveld deleted the 662-create-tracklog_event_type-enum branch August 7, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mferrera mferrera mferrera approved these changes

Assignees

@slangeveld slangeveld

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slangeveld @mferrera