Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not allow contents volumetrics and inplace_volumes. #400

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Do not allow contents volumetrics and inplace_volumes. #400

merged 2 commits into from
Dec 15, 2023

Conversation

perolavsvendsen
Copy link
Member

Solve #378

As we seem to have converged on using volumes, this PR removes the unused contents volumetrics and inplace_volumes.

jcrivenaes
jcrivenaes approved these changes Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@jcrivenaes jcrivenaes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good with some cleaning 👍

@perolavsvendsen perolavsvendsen merged commit 5a8ecea into equinor:main Dec 15, 2023
6 checks passed
@perolavsvendsen perolavsvendsen deleted the 378-remove-reduntant-volume-contents branch December 15, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcrivenaes jcrivenaes jcrivenaes approved these changes

@daniel-sol daniel-sol Awaiting requested review from daniel-sol

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@perolavsvendsen @jcrivenaes