Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore OSErrors on subprocess call of bjobs and bhist #9696

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

berland
Copy link
Contributor

@berland berland commented Jan 9, 2025

Pretend these kinds of issues are flaky. It is important not to crash on potentially intermittent failures in code that is rerun every 2 seconds.

Issue
Resolves #9694

Approach
try/catch

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@berland berland added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Jan 9, 2025
Copy link

codspeed-hq bot commented Jan 9, 2025

CodSpeed Performance Report

Merging #9696 will not alter performance

Comparing berland:allow_bhist_no_such_file_with_test (791fd8d) with main (2a3f4f0)

Summary

✅ 24 untouched benchmarks

@berland berland force-pushed the allow_bhist_no_such_file_with_test branch from 8fbf6aa to 78ef92c Compare January 9, 2025 13:09
@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 70.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 91.72%. Comparing base (c4217b1) to head (78ef92c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/ert/scheduler/openpbs_driver.py 44.44% 5 Missing ⚠️
src/ert/scheduler/slurm_driver.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9696      +/-   ##
==========================================
- Coverage   91.74%   91.72%   -0.02%     
==========================================
  Files         426      426              
  Lines       26538    26550      +12     
==========================================
+ Hits        24346    24352       +6     
- Misses       2192     2198       +6     
Flag Coverage Δ
cli-tests 39.63% <0.00%> (-0.03%) ⬇️
everest-models-test 34.14% <0.00%> (-0.02%) ⬇️
gui-tests 74.28% <0.00%> (-0.04%) ⬇️
integration-test 37.97% <0.00%> (-0.03%) ⬇️
performance-tests 51.56% <0.00%> (-0.04%) ⬇️
test 39.50% <0.00%> (-0.03%) ⬇️
unit-tests 74.22% <70.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Pretend these kinds of issues are flaky.
This makes the handling of a FileNotFoundError on bhist similar to the handling of
FileNotFoundError from bjobs. It is important not to crash on potentially intermittent
failures in code that is rerun every 2 seconds.
@berland berland force-pushed the allow_bhist_no_such_file_with_test branch from 78ef92c to 791fd8d Compare January 10, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let bjobs and bhist be flaky
2 participants