Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin numpy #9679

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Unpin numpy #9679

wants to merge 1 commit into from

Conversation

berland
Copy link
Contributor

@berland berland commented Jan 8, 2025

Issue
Resolves #8570

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@berland berland self-assigned this Jan 8, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.73%. Comparing base (839610b) to head (ca673db).
Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9679      +/-   ##
==========================================
- Coverage   91.74%   91.73%   -0.01%     
==========================================
  Files         430      426       -4     
  Lines       26639    26518     -121     
==========================================
- Hits        24439    24326     -113     
+ Misses       2200     2192       -8     
Flag Coverage Δ
cli-tests 39.70% <ø> (+0.01%) ⬆️
everest-models-test 34.22% <ø> (+0.03%) ⬆️
gui-tests 71.94% <ø> (+0.09%) ⬆️
integration-test 38.05% <ø> (-0.25%) ⬇️
performance-tests 51.65% <ø> (-0.05%) ⬇️
test 39.59% <ø> (-0.03%) ⬇️
unit-tests 74.26% <ø> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@berland
Copy link
Contributor Author

berland commented Jan 8, 2025

@berland berland added the blocked label Jan 8, 2025
Copy link

codspeed-hq bot commented Jan 8, 2025

CodSpeed Performance Report

Merging #9679 will degrade performances by 14.46%

Comparing berland:unpin_numpy (ca673db) with main (383d645)

Summary

❌ 1 regressions
✅ 23 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main berland:unpin_numpy Change
test_load_from_context[gen_x: 20, sum_x: 20 reals: 10] 6 ms 7 ms -14.46%

@berland
Copy link
Contributor Author

berland commented Jan 8, 2025

The everest tests are green because they implicitly install numpy=1.26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unpin numpy < 2
2 participants