Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show inversion errors in GUI #9678

Merged

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Jan 8, 2025

Issue
Resolves #9581

image

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@eivindjahren eivindjahren force-pushed the show_inversion_errors_in_gui branch from 8499185 to bc5946b Compare January 8, 2025 11:27
@eivindjahren eivindjahren added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Jan 8, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.71%. Comparing base (383d645) to head (bc5946b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9678      +/-   ##
==========================================
- Coverage   91.74%   91.71%   -0.03%     
==========================================
  Files         426      426              
  Lines       26518    26524       +6     
==========================================
- Hits        24328    24326       -2     
- Misses       2190     2198       +8     
Flag Coverage Δ
cli-tests 39.70% <42.85%> (-0.01%) ⬇️
everest-models-test 34.21% <14.28%> (-0.01%) ⬇️
gui-tests 71.93% <42.85%> (-0.02%) ⬇️
integration-test 38.04% <14.28%> (-0.02%) ⬇️
performance-tests 51.64% <42.85%> (-0.01%) ⬇️
test 39.58% <14.28%> (-0.01%) ⬇️
unit-tests 74.24% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Jan 8, 2025

CodSpeed Performance Report

Merging #9678 will degrade performances by 14.93%

Comparing eivindjahren:show_inversion_errors_in_gui (bc5946b) with main (383d645)

Summary

❌ 1 regressions
✅ 23 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main eivindjahren:show_inversion_errors_in_gui Change
test_load_from_context[gen_x: 20, sum_x: 20 reals: 10] 6 ms 7 ms -14.93%

Copy link
Contributor

@andreas-el andreas-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! 🏖️

@eivindjahren eivindjahren merged commit 7b2bedf into equinor:main Jan 10, 2025
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Uninformative error message in update: "Matrix is singular."
3 participants