Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pre-commits ruff 0.8.3 -> 0.8.6 #9665

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

larsevj
Copy link
Contributor

@larsevj larsevj commented Jan 6, 2025

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

Sorry, something went wrong.

@larsevj larsevj force-pushed the upgrade_pre_commits branch from 7c5c899 to 8ff34fa Compare January 6, 2025 13:58
@@ -41,7 +41,7 @@
@pytest.mark.filterwarnings("ignore::ert.config.ConfigWarning")
def test_bad_config_error_message(tmp_path):
(tmp_path / "test.ert").write_text("NUM_REL 10\n")
with pytest.raises(ConfigValidationError, match="NUM_REALIZATIONS must be set."):
with pytest.raises(ConfigValidationError, match=r"NUM_REALIZATIONS must be set."):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do a second check here? The intention is probably to include the dot . verbatim in the match, not the regexp dot. Will adding r make it into a regexp dot or the other way around?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default is apparently to convert it to regex, the r only makes it more explicit, see https://docs.astral.sh/ruff/rules/pytest-raises-ambiguous-pattern/.
I tried to escape the cases where it is clear that the regex meta-characters are intended as normal chars.

@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.71%. Comparing base (d24f588) to head (bb1a502).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/ert/services/webviz_ert_service.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9665      +/-   ##
==========================================
- Coverage   91.74%   91.71%   -0.03%     
==========================================
  Files         430      429       -1     
  Lines       26676    26672       -4     
==========================================
- Hits        24473    24463      -10     
- Misses       2203     2209       +6     
Flag Coverage Δ
cli-tests 39.70% <0.00%> (-0.02%) ⬇️
everest-models-test 34.16% <0.00%> (+<0.01%) ⬆️
gui-tests 71.81% <0.00%> (-0.04%) ⬇️
integration-test 38.25% <0.00%> (-0.01%) ⬇️
performance-tests 51.66% <0.00%> (-0.01%) ⬇️
test 39.57% <0.00%> (-0.01%) ⬇️
unit-tests 73.98% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@larsevj larsevj force-pushed the upgrade_pre_commits branch from 8fca171 to 84d1538 Compare January 6, 2025 14:21
Copy link
Contributor

@berland berland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine!

@larsevj larsevj force-pushed the upgrade_pre_commits branch from 84d1538 to bb1a502 Compare January 6, 2025 14:34
@larsevj larsevj added the release-notes:dependency Automatically categorise as dependency change in release notes label Jan 6, 2025
Copy link

codspeed-hq bot commented Jan 6, 2025

CodSpeed Performance Report

Merging #9665 will degrade performances by 12.86%

Comparing larsevj:upgrade_pre_commits (bb1a502) with main (790933d)

Summary

❌ 1 regressions
✅ 23 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main larsevj:upgrade_pre_commits Change
test_direct_dark_performance_with_storage[gen_x: 20, sum_x: 20 reals: 10-gen_data_with_obs-get_record_observations] 2.3 ms 2.6 ms -12.86%

@larsevj larsevj merged commit 3f8b320 into equinor:main Jan 6, 2025
40 of 41 checks passed
@larsevj larsevj deleted the upgrade_pre_commits branch January 6, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:dependency Automatically categorise as dependency change in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants