-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade pre-commits ruff 0.8.3 -> 0.8.6 #9665
Conversation
7c5c899
to
8ff34fa
Compare
tests/ert/ui_tests/cli/test_cli.py
Outdated
@@ -41,7 +41,7 @@ | |||
@pytest.mark.filterwarnings("ignore::ert.config.ConfigWarning") | |||
def test_bad_config_error_message(tmp_path): | |||
(tmp_path / "test.ert").write_text("NUM_REL 10\n") | |||
with pytest.raises(ConfigValidationError, match="NUM_REALIZATIONS must be set."): | |||
with pytest.raises(ConfigValidationError, match=r"NUM_REALIZATIONS must be set."): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you do a second check here? The intention is probably to include the dot .
verbatim in the match, not the regexp dot. Will adding r
make it into a regexp dot or the other way around?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default is apparently to convert it to regex, the r
only makes it more explicit, see https://docs.astral.sh/ruff/rules/pytest-raises-ambiguous-pattern/.
I tried to escape the cases where it is clear that the regex meta-characters are intended as normal chars.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9665 +/- ##
==========================================
- Coverage 91.74% 91.71% -0.03%
==========================================
Files 430 429 -1
Lines 26676 26672 -4
==========================================
- Hits 24473 24463 -10
- Misses 2203 2209 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
8fca171
to
84d1538
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine!
84d1538
to
bb1a502
Compare
CodSpeed Performance ReportMerging #9665 will degrade performances by 12.86%Comparing Summary
Benchmarks breakdown
|
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"'
)When applicable