Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid UserWarning when vmin==vmax in std_dev plot #9659

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

berland
Copy link
Contributor

@berland berland commented Jan 6, 2025

Issue
Resolves #9657

Approach
if

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@berland berland added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Jan 6, 2025
@berland berland self-assigned this Jan 6, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.71%. Comparing base (839610b) to head (f433ef8).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9659      +/-   ##
==========================================
- Coverage   91.74%   91.71%   -0.03%     
==========================================
  Files         430      430              
  Lines       26639    26640       +1     
==========================================
- Hits        24439    24434       -5     
- Misses       2200     2206       +6     
Flag Coverage Δ
cli-tests 39.69% <0.00%> (-0.01%) ⬇️
everest-models-test 34.18% <0.00%> (-0.01%) ⬇️
gui-tests 71.83% <100.00%> (-0.03%) ⬇️
integration-test 38.29% <0.00%> (-0.01%) ⬇️
performance-tests 51.68% <0.00%> (-0.01%) ⬇️
test 39.62% <0.00%> (+<0.01%) ⬆️
unit-tests 73.99% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Jan 6, 2025

CodSpeed Performance Report

Merging #9659 will not alter performance

Comparing berland:avoid_userwarning (f433ef8) with main (7d73f74)

Summary

✅ 24 untouched benchmarks

@sondreso sondreso merged commit 23015dc into equinor:main Jan 7, 2025
41 checks passed
@berland berland deleted the avoid_userwarning branch January 9, 2025 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UserWarning displayed when plotting PORO in snake_oil_field after ES_MDA
3 participants