Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nicer error message when init fails #9653

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

frode-aarstad
Copy link
Contributor

@frode-aarstad frode-aarstad commented Jan 6, 2025

Issue
Resolves #9466

Approach
To test.

pip install ropt==0.4.3
everest run test-data/everest/math_func/config_advanced.yml

Should get a error message not a stacktrace

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@frode-aarstad frode-aarstad self-assigned this Jan 6, 2025
@frode-aarstad frode-aarstad added the release-notes:improvement Automatically categorise as improvement in release notes label Jan 6, 2025
@frode-aarstad frode-aarstad changed the title Add nicer error when init fails Add nicer error message when init fails Jan 6, 2025
Copy link

codspeed-hq bot commented Jan 6, 2025

CodSpeed Performance Report

Merging #9653 will not alter performance

Comparing frode-aarstad:try-init (decfdfd) with main (7d73f74)

Summary

✅ 24 untouched benchmarks

Copy link
Contributor

@verveerpj verveerpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 91.70%. Comparing base (7d73f74) to head (decfdfd).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/everest/__init__.py 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9653      +/-   ##
==========================================
- Coverage   91.71%   91.70%   -0.02%     
==========================================
  Files         430      430              
  Lines       26639    26644       +5     
==========================================
+ Hits        24433    24434       +1     
- Misses       2206     2210       +4     
Flag Coverage Δ
cli-tests 39.69% <ø> (ø)
everest-models-test 34.18% <ø> (-0.02%) ⬇️
gui-tests 71.83% <ø> (ø)
integration-test 38.30% <ø> (ø)
performance-tests 51.78% <ø> (+0.09%) ⬆️
test 39.62% <ø> (+0.01%) ⬆️
unit-tests 73.98% <33.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frode-aarstad frode-aarstad merged commit 6982b4d into equinor:main Jan 6, 2025
41 checks passed
@frode-aarstad frode-aarstad deleted the try-init branch January 6, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:improvement Automatically categorise as improvement in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some validations can cause Everest to give a traceback instead of a nice error message
3 participants