Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix changed functionality after refactoring testing for test_logging_setup and test_https_requests #9649

Closed
wants to merge 1 commit into from

Conversation

DanSava
Copy link
Contributor

@DanSava DanSava commented Jan 6, 2025

Backport fixes to version-12.1

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

Copy link

codspeed-hq bot commented Jan 6, 2025

CodSpeed Performance Report

Merging #9649 will not alter performance

Comparing DanSava:backport_fix (3460ee2) with main (719a81e)

Summary

✅ 24 untouched benchmarks

@DanSava DanSava self-assigned this Jan 6, 2025
@berland
Copy link
Contributor

berland commented Jan 6, 2025

Included in #9660

@berland berland closed this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants