Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change needed for updated everest-models #9634

Merged

Conversation

frode-aarstad
Copy link
Contributor

Needed after the change to everest-models. equinor/everest-models#87

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@frode-aarstad frode-aarstad added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Jan 2, 2025
@frode-aarstad frode-aarstad self-assigned this Jan 2, 2025
Copy link

codspeed-hq bot commented Jan 2, 2025

CodSpeed Performance Report

Merging #9634 will not alter performance

Comparing frode-aarstad:fix-for-everest-models-fix (d5ae03a) with main (929d59b)

Summary

✅ 24 untouched benchmarks

@berland
Copy link
Contributor

berland commented Jan 2, 2025

(needs backport to version-12.1 as well)

@frode-aarstad frode-aarstad merged commit 7e8d20c into equinor:main Jan 3, 2025
38 of 41 checks passed
@frode-aarstad frode-aarstad deleted the fix-for-everest-models-fix branch January 3, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants