Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused async_run #9609

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Remove unused async_run #9609

merged 1 commit into from
Dec 20, 2024

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Dec 20, 2024

Approach
🧹

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@oyvindeide oyvindeide added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Dec 20, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.85%. Comparing base (1889e2a) to head (b2662bd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9609      +/-   ##
==========================================
- Coverage   91.85%   91.85%   -0.01%     
==========================================
  Files         433      432       -1     
  Lines       26813    26791      -22     
==========================================
- Hits        24630    24609      -21     
+ Misses       2183     2182       -1     
Flag Coverage Δ
cli-tests 39.74% <ø> (ø)
everest-models-test 34.60% <ø> (+<0.01%) ⬆️
gui-tests 72.12% <ø> (+0.01%) ⬆️
integration-test 38.73% <ø> (-0.02%) ⬇️
performance-tests 51.94% <ø> (ø)
test 40.03% <ø> (-0.06%) ⬇️
unit-tests 74.18% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Dec 20, 2024

CodSpeed Performance Report

Merging #9609 will not alter performance

Comparing oyvindeide:remove_async (b2662bd) with main (1889e2a)

Summary

✅ 24 untouched benchmarks

@oyvindeide oyvindeide merged commit 1bd4fe1 into equinor:main Dec 20, 2024
41 checks passed
@oyvindeide oyvindeide deleted the remove_async branch December 20, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants