Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SIMULATION_JOB keyword #9606

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Remove SIMULATION_JOB keyword #9606

merged 2 commits into from
Jan 7, 2025

Conversation

DanSava
Copy link
Contributor

@DanSava DanSava commented Dec 20, 2024

Issue
Resolves #4955

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.77%. Comparing base (d82fc01) to head (94f1696).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9606      +/-   ##
==========================================
+ Coverage   91.74%   91.77%   +0.02%     
==========================================
  Files         426      426              
  Lines       26559    26551       -8     
==========================================
- Hits        24367    24366       -1     
+ Misses       2192     2185       -7     
Flag Coverage Δ
cli-tests 39.69% <71.42%> (-0.02%) ⬇️
everest-models-test 34.21% <90.90%> (+0.05%) ⬆️
gui-tests 71.95% <71.42%> (+0.09%) ⬆️
integration-test 38.08% <81.81%> (+0.04%) ⬆️
performance-tests 51.63% <28.57%> (-0.01%) ⬇️
test 39.45% <90.90%> (+0.04%) ⬆️
unit-tests 74.18% <45.45%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Dec 20, 2024

CodSpeed Performance Report

Merging #9606 will not alter performance

Comparing remove-simulation-job (94f1696) with main (d82fc01)

Summary

✅ 24 untouched benchmarks

@DanSava DanSava force-pushed the remove-simulation-job branch 4 times, most recently from 44499fd to 1120a22 Compare December 20, 2024 13:57
Copy link
Contributor

@verveerpj verveerpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sondreso sondreso added the release-notes:breaking-change Automatically categorise as breaking change in release notes label Jan 6, 2025
Copy link
Collaborator

@oyvindeide oyvindeide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really nice, but would be great with a migration error with a path to resoluation if anyone is using this, it will currently just show up as a warning.

@DanSava DanSava force-pushed the remove-simulation-job branch 2 times, most recently from 6c159de to 61a0d05 Compare January 7, 2025 10:18
@DanSava DanSava requested a review from oyvindeide January 7, 2025 10:18
@DanSava DanSava self-assigned this Jan 7, 2025
Copy link
Collaborator

@oyvindeide oyvindeide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a minor comment, is it possible to write out an example of how FORWARD_MODEL should be configured with the same args?

src/ert/config/parsing/config_schema_deprecations.py Outdated Show resolved Hide resolved
@DanSava DanSava force-pushed the remove-simulation-job branch from 61a0d05 to 94f1696 Compare January 7, 2025 11:32
@DanSava DanSava merged commit 2f81dd1 into main Jan 7, 2025
41 checks passed
@DanSava DanSava deleted the remove-simulation-job branch January 7, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:breaking-change Automatically categorise as breaking change in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove SIMULATION_JOB
5 participants