-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove SIMULATION_JOB keyword #9606
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #9606 +/- ##
==========================================
+ Coverage 91.74% 91.77% +0.02%
==========================================
Files 426 426
Lines 26559 26551 -8
==========================================
- Hits 24367 24366 -1
+ Misses 2192 2185 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #9606 will not alter performanceComparing Summary
|
44499fd
to
1120a22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really nice, but would be great with a migration error with a path to resoluation if anyone is using this, it will currently just show up as a warning.
6c159de
to
61a0d05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a minor comment, is it possible to write out an example of how FORWARD_MODEL
should be configured with the same args?
61a0d05
to
94f1696
Compare
Issue
Resolves #4955
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"'
)When applicable