Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move max_runtime to QueueConfig #9605

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Dec 20, 2024

Some drive by cleaning, does not really seem to belong with the analysis config, but with the queue_config.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@oyvindeide oyvindeide added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Dec 20, 2024
@oyvindeide oyvindeide requested a review from berland December 20, 2024 11:38
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.87%. Comparing base (1af592d) to head (a1dc57d).
Report is 41 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9605      +/-   ##
==========================================
+ Coverage   91.85%   91.87%   +0.01%     
==========================================
  Files         433      433              
  Lines       26768    26811      +43     
==========================================
+ Hits        24589    24632      +43     
  Misses       2179     2179              
Flag Coverage Δ
cli-tests 39.74% <100.00%> (-0.04%) ⬇️
everest-models-test 34.60% <100.00%> (-0.08%) ⬇️
gui-tests 72.10% <100.00%> (-0.04%) ⬇️
integration-test 38.76% <100.00%> (+1.52%) ⬆️
performance-tests 51.94% <100.00%> (-0.04%) ⬇️
test 40.06% <100.00%> (-0.40%) ⬇️
unit-tests 74.13% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@berland berland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 👍🏻

Copy link

codspeed-hq bot commented Dec 20, 2024

CodSpeed Performance Report

Merging #9605 will not alter performance

Comparing oyvindeide:move_max_runtime (a1dc57d) with main (1889e2a)

Summary

✅ 24 untouched benchmarks

@oyvindeide oyvindeide merged commit ead6423 into equinor:main Dec 20, 2024
41 checks passed
@oyvindeide oyvindeide deleted the move_max_runtime branch December 20, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants