Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate triangular dist parameters on startup #9596

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

larsevj
Copy link
Contributor

@larsevj larsevj commented Dec 19, 2024

Issue
Resolves #9520

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

Copy link

codspeed-hq bot commented Dec 19, 2024

CodSpeed Performance Report

Merging #9596 will degrade performances by 10.92%

Comparing larsevj:validate_triangular_dist (f59199c) with main (0906db9)

Summary

❌ 1 regressions
✅ 21 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main larsevj:validate_triangular_dist Change
test_direct_dark_performance[gen_x: 20, sum_x: 20 reals: 10-summary-get_parameters] 148.9 µs 167.2 µs -10.92%

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.87%. Comparing base (e5c7953) to head (f59199c).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9596      +/-   ##
==========================================
+ Coverage   91.86%   91.87%   +0.01%     
==========================================
  Files         433      433              
  Lines       26775    26788      +13     
==========================================
+ Hits        24596    24611      +15     
+ Misses       2179     2177       -2     
Flag Coverage Δ
cli-tests 39.74% <20.00%> (-0.02%) ⬇️
everest-models-test 34.56% <0.00%> (-0.02%) ⬇️
gui-tests 72.12% <20.00%> (+<0.01%) ⬆️
integration-test 37.16% <0.00%> (-0.03%) ⬇️
performance-tests 51.94% <20.00%> (-0.02%) ⬇️
test 40.68% <0.00%> (+0.24%) ⬆️
unit-tests 74.18% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@larsevj larsevj force-pushed the validate_triangular_dist branch from 45d972a to f59199c Compare December 19, 2024 12:23
@larsevj larsevj requested a review from eivindjahren December 19, 2024 12:26
@larsevj larsevj added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Dec 19, 2024
Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@larsevj larsevj merged commit d9088eb into equinor:main Dec 19, 2024
40 of 41 checks passed
@larsevj larsevj deleted the validate_triangular_dist branch December 19, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameters for triangular distribution is not validated
3 participants