Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change CASE_NAME to BATCH_NAME #9593

Merged

Conversation

StephanDeHoop
Copy link
Contributor

Issue
Resolves #9592

Approach
CASE_NAME is a bit of a weird name, BATCH_NAME makes more sense.

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@StephanDeHoop
Copy link
Contributor Author

StephanDeHoop commented Dec 19, 2024

There is one other place where we use CASE_NAME: test-data/ert/batch_sim/batch_sim.ert RUNPATH <STORAGE>/runpath/<CASE_NAME>/realization-<IENS>/iter-<ITER> , should we change it here to or is this an ERT thing?

@StephanDeHoop StephanDeHoop force-pushed the change_case_name_to_batch_name branch from e0898d5 to 146b432 Compare December 19, 2024 07:25
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.86%. Comparing base (2b41fe2) to head (146b432).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9593   +/-   ##
=======================================
  Coverage   91.85%   91.86%           
=======================================
  Files         433      433           
  Lines       26775    26775           
=======================================
+ Hits        24594    24596    +2     
+ Misses       2181     2179    -2     
Flag Coverage Δ
cli-tests 39.75% <0.00%> (ø)
everest-models-test 34.58% <100.00%> (+<0.01%) ⬆️
gui-tests 72.15% <0.00%> (+0.02%) ⬆️
integration-test 37.22% <100.00%> (+0.02%) ⬆️
performance-tests 51.95% <0.00%> (-0.03%) ⬇️
test 40.46% <100.00%> (+<0.01%) ⬆️
unit-tests 74.19% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Dec 19, 2024

CodSpeed Performance Report

Merging #9593 will not alter performance

Comparing StephanDeHoop:change_case_name_to_batch_name (146b432) with main (2b41fe2)

Summary

✅ 22 untouched benchmarks

@StephanDeHoop StephanDeHoop marked this pull request as ready for review December 19, 2024 09:14
Copy link
Contributor

@yngve-sk yngve-sk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@StephanDeHoop StephanDeHoop merged commit 0906db9 into equinor:main Dec 19, 2024
41 checks passed
@StephanDeHoop StephanDeHoop deleted the change_case_name_to_batch_name branch December 19, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change CASE_NAME to BATCH_NAME
3 participants