Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove printing of snapshots in gui test #9588

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

larsevj
Copy link
Contributor

@larsevj larsevj commented Dec 18, 2024

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@larsevj larsevj requested a review from jonathan-eq December 18, 2024 13:37
@larsevj larsevj added the release-notes:skip If there should be no mention of this in release notes label Dec 18, 2024
Copy link

codspeed-hq bot commented Dec 18, 2024

CodSpeed Performance Report

Merging #9588 will not alter performance

Comparing larsevj:remove_print_from_test (157123c) with main (a0dc76e)

Summary

✅ 22 untouched benchmarks

Copy link
Contributor

@jonathan-eq jonathan-eq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find!

@larsevj larsevj merged commit e5c7953 into equinor:main Dec 19, 2024
41 checks passed
@larsevj larsevj deleted the remove_print_from_test branch December 19, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants