Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix key error on empty summary observations in plotter #9568

Merged

Conversation

yngve-sk
Copy link
Contributor

Issue
Resolves #9560

Copy link

codspeed-hq bot commented Dec 16, 2024

CodSpeed Performance Report

Merging #9568 will not alter performance

Comparing yngve-sk:24.12.16.bugfix2-emptyensembleresponses (571ca2c) with main (0e19012)

Summary

✅ 22 untouched benchmarks

@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.85%. Comparing base (0d10c5d) to head (571ca2c).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9568      +/-   ##
==========================================
- Coverage   91.87%   91.85%   -0.02%     
==========================================
  Files         433      433              
  Lines       26768    26770       +2     
==========================================
- Hits        24593    24590       -3     
- Misses       2175     2180       +5     
Flag Coverage Δ
cli-tests 39.76% <ø> (-0.03%) ⬇️
everest-models-test 34.58% <ø> (-0.09%) ⬇️
gui-tests 72.14% <ø> (+0.01%) ⬆️
integration-test 37.20% <ø> (-0.02%) ⬇️
performance-tests 51.94% <ø> (-0.02%) ⬇️
test 40.47% <ø> (+<0.01%) ⬆️
unit-tests 74.18% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eivindjahren eivindjahren changed the title Fixup keyerror bug Fix key error on empty summary observations in plotter Dec 18, 2024
@eivindjahren eivindjahren merged commit b17963f into equinor:main Dec 18, 2024
41 checks passed
@eivindjahren eivindjahren deleted the 24.12.16.bugfix2-emptyensembleresponses branch December 18, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyError in plotapi /records/observations
3 participants