Version 12.0 havb #9565
Merged
Version 12.0 havb #9565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The batching interval and size can maybe be tuned slightly, before that it will be quite interesting to know how often message processing is postponed. This logging feature existed in the sync version of the ensemble evaluator, but was not carried over in 509c224.
There exists logs that a user has overspent with a factor of 1.0. This is not very interesting, so skip logging anything that we don't find significant.
The function careful_copy_file was not able to handle None as a target. Added the functionality as probably originally intended and added tests.
larsevj
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport changes to logging and a minor bugfix in careful_copy
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable