Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove function that gave impression everest was logging to azure #9558

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Dec 16, 2024

Issue
Resolves #9199

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@oyvindeide oyvindeide self-assigned this Dec 16, 2024
@oyvindeide oyvindeide added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Dec 16, 2024
@oyvindeide oyvindeide marked this pull request as ready for review December 16, 2024 12:07
This gave the impression that we were logging all usage to azure, which
is not the case. Also fixed a bug where only a single plugin could
register a logging handle.
@oyvindeide oyvindeide force-pushed the remove_azure_mentions branch from daaa657 to 9d417cb Compare December 16, 2024 12:10
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.87%. Comparing base (72babc5) to head (9d417cb).

Files with missing lines Patch % Lines
src/everest/plugins/everest_plugin_manager.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9558      +/-   ##
==========================================
+ Coverage   91.85%   91.87%   +0.02%     
==========================================
  Files         433      433              
  Lines       26767    26761       -6     
==========================================
  Hits        24586    24586              
+ Misses       2181     2175       -6     
Flag Coverage Δ
cli-tests 39.78% <ø> (ø)
everest-models-test 34.67% <81.81%> (-0.02%) ⬇️
gui-tests 72.15% <ø> (+<0.01%) ⬆️
integration-test 37.22% <72.72%> (-0.02%) ⬇️
performance-tests 51.97% <ø> (ø)
test 40.48% <90.90%> (-0.01%) ⬇️
unit-tests 74.16% <45.45%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Dec 16, 2024

CodSpeed Performance Report

Merging #9558 will degrade performances by 50.57%

Comparing oyvindeide:remove_azure_mentions (9d417cb) with main (72babc5)

Summary

❌ 1 regressions
✅ 22 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main oyvindeide:remove_azure_mentions Change
test_gui_snapshot 3.2 s 6.5 s -50.57%

@oyvindeide oyvindeide merged commit 8fa3040 into equinor:main Dec 20, 2024
40 of 41 checks passed
@oyvindeide oyvindeide deleted the remove_azure_mentions branch December 20, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Remove direct Azure link
3 participants