-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary wrapper forward_model_data_to_json #9551
Conversation
Thanks for your contribution, this looks good! Could up update the PR title so it becomes suitable for release notes? |
e059515
to
20d18aa
Compare
CodSpeed Performance ReportMerging #9551 will improve performances by 80.71%Comparing Summary
Benchmarks breakdown
|
20d18aa
to
6510e1e
Compare
6510e1e
to
997651b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9551 +/- ##
==========================================
- Coverage 91.87% 91.86% -0.01%
==========================================
Files 433 433
Lines 26768 26762 -6
==========================================
- Hits 24593 24585 -8
- Misses 2175 2177 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Issue
Resolves #9545
Approach
Removes extra wrapper layer in ert_config.py (forward_model_data_to_json) and updates tests related to it.
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"'
)When applicable