Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have Ert sidebar have correct focus on startup and when simulating #9548

Merged

Conversation

andreas-el
Copy link
Contributor

@andreas-el andreas-el commented Dec 13, 2024

Issue
Resolves #9538

Screenshot 2024-12-13 at 15 29 45

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@andreas-el andreas-el added the release-notes:skip If there should be no mention of this in release notes label Dec 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.86%. Comparing base (72babc5) to head (3e2f7b2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9548      +/-   ##
==========================================
+ Coverage   91.85%   91.86%   +0.01%     
==========================================
  Files         433      433              
  Lines       26767    26768       +1     
==========================================
+ Hits        24586    24591       +5     
+ Misses       2181     2177       -4     
Flag Coverage Δ
cli-tests 39.78% <0.00%> (-0.01%) ⬇️
everest-models-test 34.67% <0.00%> (-0.03%) ⬇️
gui-tests 72.15% <100.00%> (+<0.01%) ⬆️
integration-test 37.21% <0.00%> (-0.03%) ⬇️
performance-tests 51.97% <0.00%> (-0.01%) ⬇️
test 40.48% <0.00%> (-0.01%) ⬇️
unit-tests 74.17% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Dec 13, 2024

CodSpeed Performance Report

Merging #9548 will not alter performance

Comparing andreas-el:set_simulation_button_default_selected (3e2f7b2) with main (72babc5)

Summary

✅ 23 untouched benchmarks

Copy link
Contributor

@berland berland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖱️

Copy link
Contributor

@AugustoMagalhaes AugustoMagalhaes Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When working on a new issue I've realized I've forgot to mark this as default (I'm sorry for that btw), but also that when simulation starts there is no selection change to the "Simulation status" button (self.results_button). If you want, you could also add this code to post_init function to achieve that:

 def post_init(self) -> None:
        experiment_panel = ExperimentPanel(
            self.ert_config,
            self.notifier,
            self.config_file,
            self.facade.get_ensemble_size(),
        )
        # This code snippet below
        experiment_panel.experiment_started.connect(
            lambda: self.results_button.setChecked(True)
        )
...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense. Nice catch @AugustoMagalhaes !

@andreas-el andreas-el force-pushed the set_simulation_button_default_selected branch from e101b82 to 3e2f7b2 Compare December 16, 2024 11:33
@andreas-el andreas-el changed the title Set simulation button default selected Have Ert sidebar have correct focus on startup and when simulating Dec 16, 2024
@andreas-el andreas-el requested a review from berland December 16, 2024 11:39
@berland
Copy link
Contributor

berland commented Dec 16, 2024

Looks smooth!

@andreas-el andreas-el merged commit 0d10c5d into equinor:main Dec 16, 2024
41 checks passed
@andreas-el andreas-el deleted the set_simulation_button_default_selected branch December 16, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidebar in ert has no focus on startup
4 participants