-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have Ert sidebar have correct focus on startup and when simulating #9548
Have Ert sidebar have correct focus on startup and when simulating #9548
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9548 +/- ##
==========================================
+ Coverage 91.85% 91.86% +0.01%
==========================================
Files 433 433
Lines 26767 26768 +1
==========================================
+ Hits 24586 24591 +5
+ Misses 2181 2177 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #9548 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🖱️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When working on a new issue I've realized I've forgot to mark this as default (I'm sorry for that btw), but also that when simulation starts there is no selection change to the "Simulation status" button (self.results_button). If you want, you could also add this code to post_init function to achieve that:
def post_init(self) -> None:
experiment_panel = ExperimentPanel(
self.ert_config,
self.notifier,
self.config_file,
self.facade.get_ensemble_size(),
)
# This code snippet below
experiment_panel.experiment_started.connect(
lambda: self.results_button.setChecked(True)
)
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense. Nice catch @AugustoMagalhaes !
e101b82
to
3e2f7b2
Compare
Looks smooth! |
Issue
Resolves #9538
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"'
)When applicable