Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ruff issues #9541

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Fix ruff issues #9541

merged 1 commit into from
Dec 13, 2024

Conversation

berland
Copy link
Contributor

@berland berland commented Dec 13, 2024

These issues sneaked into main via a rebase while ruff was upgraded

Issue
Resolves style failure in main.

Approach
ruff check --fix .

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

These issues sneaked into main via a rebase while ruff was upgraded
@berland berland enabled auto-merge (rebase) December 13, 2024 11:47
@berland berland added the release-notes:skip If there should be no mention of this in release notes label Dec 13, 2024
@berland berland merged commit 0ca408f into equinor:main Dec 13, 2024
39 checks passed
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.86%. Comparing base (9725d7d) to head (518edbd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9541   +/-   ##
=======================================
  Coverage   91.86%   91.86%           
=======================================
  Files         433      433           
  Lines       26768    26768           
=======================================
  Hits        24590    24590           
  Misses       2178     2178           
Flag Coverage Δ
cli-tests 39.78% <ø> (ø)
everest-models-test 34.69% <ø> (+0.01%) ⬆️
gui-tests 72.15% <ø> (+0.02%) ⬆️
integration-test 37.21% <ø> (ø)
performance-tests 51.97% <ø> (-0.01%) ⬇️
test 40.48% <ø> (+<0.01%) ⬆️
unit-tests 74.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@berland berland deleted the fix_ruff branch December 27, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants