Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused test markers #9531

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Dec 13, 2024

Clean up some test markers

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@oyvindeide oyvindeide changed the title Remove unused Remove unused test markers Dec 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.86%. Comparing base (72babc5) to head (e36e1cb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9531      +/-   ##
==========================================
+ Coverage   91.85%   91.86%   +0.01%     
==========================================
  Files         433      433              
  Lines       26767    26767              
==========================================
+ Hits        24586    24590       +4     
+ Misses       2181     2177       -4     
Flag Coverage Δ
cli-tests 39.78% <ø> (ø)
everest-models-test 34.67% <ø> (-0.03%) ⬇️
gui-tests 72.13% <ø> (-0.03%) ⬇️
integration-test 37.21% <ø> (-0.03%) ⬇️
performance-tests 52.07% <ø> (+0.09%) ⬆️
test 40.48% <ø> (ø)
unit-tests 74.13% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@DanSava DanSava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🍥

Copy link

codspeed-hq bot commented Dec 16, 2024

CodSpeed Performance Report

Merging #9531 will improve performances by 26.32%

Comparing oyvindeide:remove_unused (e36e1cb) with main (72babc5)

Summary

⚡ 1 improvements
✅ 22 untouched benchmarks

Benchmarks breakdown

Benchmark main oyvindeide:remove_unused Change
test_gui_snapshot 3.2 s 2.6 s +26.32%

@oyvindeide oyvindeide merged commit 87cbac3 into equinor:main Dec 16, 2024
41 checks passed
@oyvindeide oyvindeide deleted the remove_unused branch December 16, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants