Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce logging to file #9507

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

larsevj
Copy link
Contributor

@larsevj larsevj commented Dec 11, 2024

Removes the logging of gui events to the log file.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.86%. Comparing base (5ae6ece) to head (cf7707a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9507   +/-   ##
=======================================
  Coverage   91.86%   91.86%           
=======================================
  Files         433      433           
  Lines       26768    26767    -1     
=======================================
  Hits        24590    24590           
+ Misses       2178     2177    -1     
Flag Coverage Δ
cli-tests 39.78% <ø> (+<0.01%) ⬆️
everest-models-test 34.67% <ø> (+<0.01%) ⬆️
gui-tests 72.16% <ø> (+<0.01%) ⬆️
integration-test 37.22% <ø> (+<0.01%) ⬆️
performance-tests 51.97% <ø> (+0.01%) ⬆️
test 40.45% <ø> (-0.03%) ⬇️
unit-tests 74.14% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@larsevj larsevj force-pushed the reduce_logging_to_file branch from 1cdf2b7 to e3c8574 Compare December 11, 2024 16:27
@larsevj larsevj requested a review from sondreso December 12, 2024 08:47
@larsevj larsevj added the release-notes:misc Automatically categorise as miscellaneous change in release notes label Dec 12, 2024
Copy link
Collaborator

@sondreso sondreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📜

@larsevj larsevj force-pushed the reduce_logging_to_file branch from e3c8574 to ef15ec7 Compare December 13, 2024 10:51
@larsevj larsevj enabled auto-merge (rebase) December 13, 2024 10:56
@larsevj larsevj disabled auto-merge December 13, 2024 14:04
- Also increases log level for websockets or asyncio
@larsevj larsevj force-pushed the reduce_logging_to_file branch from ef15ec7 to cf7707a Compare December 13, 2024 14:15
Copy link

codspeed-hq bot commented Dec 13, 2024

CodSpeed Performance Report

Merging #9507 will improve performances by 12.73%

Comparing larsevj:reduce_logging_to_file (cf7707a) with main (5ae6ece)

Summary

⚡ 1 improvements
✅ 22 untouched benchmarks

Benchmarks breakdown

Benchmark main larsevj:reduce_logging_to_file Change
test_gui_snapshot 3.7 s 3.2 s +12.73%

@larsevj larsevj merged commit ebe548e into equinor:main Dec 13, 2024
41 checks passed
@larsevj larsevj deleted the reduce_logging_to_file branch December 13, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:misc Automatically categorise as miscellaneous change in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants