Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyupgrade UP rule to ruff #9499

Merged
merged 7 commits into from
Dec 10, 2024
Merged

Conversation

larsevj
Copy link
Contributor

@larsevj larsevj commented Dec 10, 2024

See https://docs.astral.sh/ruff/rules/#pydocstyle-d

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@larsevj larsevj force-pushed the add_ruff_up_rules branch 3 times, most recently from 66cda31 to f557943 Compare December 10, 2024 13:32
@larsevj larsevj self-assigned this Dec 10, 2024
@larsevj larsevj added the release-notes:skip If there should be no mention of this in release notes label Dec 10, 2024
@larsevj larsevj requested a review from eivindjahren December 10, 2024 13:40
@eivindjahren eivindjahren enabled auto-merge (squash) December 10, 2024 14:11
@eivindjahren eivindjahren enabled auto-merge (squash) December 10, 2024 14:11
@eivindjahren eivindjahren enabled auto-merge (squash) December 10, 2024 20:28
@eivindjahren eivindjahren merged commit c9d43bc into equinor:main Dec 10, 2024
39 checks passed
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 97.73913% with 26 lines in your changes missing coverage. Please review.

Project coverage is 91.94%. Comparing base (82972b0) to head (4bf6bc9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../tools/plot/customize/limits_customization_view.py 77.27% 5 Missing ⚠️
src/_ert/forward_model_runner/client.py 60.00% 4 Missing ⚠️
src/ert/gui/main.py 42.85% 4 Missing ⚠️
src/ert/storage/local_ensemble.py 88.23% 2 Missing ⚠️
src/ert/__main__.py 90.90% 1 Missing ⚠️
src/ert/ensemble_evaluator/_ensemble.py 75.00% 1 Missing ⚠️
src/ert/ensemble_evaluator/evaluator.py 87.50% 1 Missing ⚠️
src/ert/gui/simulation/view/update.py 75.00% 1 Missing ⚠️
...ert/gui/tools/plot/customize/customization_view.py 83.33% 1 Missing ⚠️
src/ert/gui/tools/plot/data_type_keys_widget.py 50.00% 1 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9499      +/-   ##
==========================================
+ Coverage   91.92%   91.94%   +0.01%     
==========================================
  Files         433      433              
  Lines       26734    26748      +14     
==========================================
+ Hits        24575    24593      +18     
+ Misses       2159     2155       -4     
Flag Coverage Δ
cli-tests 39.41% <51.16%> (+0.03%) ⬆️
everest-models-test 34.70% <54.17%> (+0.01%) ⬆️
gui-tests 72.15% <85.41%> (+0.01%) ⬆️
integration-test 36.95% <55.21%> (+<0.01%) ⬆️
performance-tests 52.00% <80.44%> (+0.16%) ⬆️
test 40.62% <56.69%> (-0.02%) ⬇️
unit-tests 74.14% <90.52%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants