Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cached_example in test_everexport.py #9495

Merged

Conversation

yngve-sk
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.83%. Comparing base (60fa1a6) to head (5f0ff20).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9495      +/-   ##
==========================================
- Coverage   91.86%   91.83%   -0.04%     
==========================================
  Files         433      433              
  Lines       26737    26748      +11     
==========================================
+ Hits        24561    24563       +2     
- Misses       2176     2185       +9     
Flag Coverage Δ
cli-tests 39.41% <ø> (+0.04%) ⬆️
everest-models-test 34.70% <ø> (-0.04%) ⬇️
gui-tests 72.15% <ø> (-0.03%) ⬇️
integration-test 36.95% <ø> (-0.04%) ⬇️
performance-tests 52.06% <ø> (+0.14%) ⬆️
test 40.50% <ø> (-0.19%) ⬇️
unit-tests 74.14% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yngve-sk yngve-sk self-assigned this Dec 10, 2024
Copy link
Contributor

@DanSava DanSava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 🕺

Comment on lines 68 to 69
# NOTE: there is probably a bug concerning output folders. Everexport
# seems to assume that the folder where the file will be saved exists.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is no longer the case and can be removed

@yngve-sk yngve-sk enabled auto-merge (rebase) December 11, 2024 12:41
@yngve-sk yngve-sk merged commit 05b33a5 into equinor:main Dec 11, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants