Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of deprecated types #9494

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Dec 10, 2024

List, Dict, DefaultDict, Set, & Tuple are deprecated since python 3.9, but supported without deprecation warning at least until python 3.14. Then there wil least two versions with deprecation warnings before removal so not removed until python 3.16 (2027).

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@eivindjahren eivindjahren force-pushed the remove_deprecated_types branch 2 times, most recently from bda3f35 to a6cefc6 Compare December 10, 2024 10:43
src/_ert/events.py Outdated Show resolved Hide resolved
@eivindjahren eivindjahren force-pushed the remove_deprecated_types branch 10 times, most recently from 44cdd01 to 7f8e554 Compare December 10, 2024 12:27
@eivindjahren eivindjahren force-pushed the remove_deprecated_types branch from 7f8e554 to 27d1a35 Compare December 10, 2024 12:37
Copy link
Contributor

@berland berland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@eivindjahren eivindjahren enabled auto-merge (rebase) December 10, 2024 12:43
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 99.84177% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.93%. Comparing base (68d01c7) to head (27d1a35).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/ert/services/_storage_main.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9494      +/-   ##
==========================================
+ Coverage   91.87%   91.93%   +0.06%     
==========================================
  Files         433      433              
  Lines       26752    26734      -18     
==========================================
  Hits        24579    24579              
+ Misses       2173     2155      -18     
Flag Coverage Δ
cli-tests 39.37% <68.82%> (-0.03%) ⬇️
everest-models-test 34.68% <68.35%> (-0.03%) ⬇️
gui-tests 72.16% <85.44%> (+0.01%) ⬆️
integration-test 36.94% <68.67%> (-0.03%) ⬇️
performance-tests 51.94% <85.12%> (-0.05%) ⬇️
test 40.64% <68.51%> (-0.03%) ⬇️
unit-tests 74.12% <96.51%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eivindjahren eivindjahren merged commit 82972b0 into equinor:main Dec 10, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants