New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add conda support to activation script #9436

Open

cmrqs wants to merge 2 commits into equinor:main from cmrqs:conda-support

Contributor

cmrqs commented Dec 3, 2024

Issue
Resolves #9435

Approach
If VIRTUAL_ENV environment variable is not set, the CONDA_ENV variable is read.

PR title captures the intent of the changes, and is fitting for release notes.
Added appropriate release note label
Commit history is consistent and clean, in line with the contribution guidelines.
Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

When there are user facing changes: Updated documentation
New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
Large PR: Prepare changes in small commits for more convenient review
Bug fix: Add regression test for the bug
Bug fix: Create Backport PR to latest release

eivindjahren added the christmas-review label

cmrqs added 2 commits

December 16, 2024 09:15


          Add conda support to activation script

90e74c3


          Add unit tests for conda activation script

8999ce3

cmrqs force-pushed the conda-support branch from fd40939 to 8999ce3 Compare

December 16, 2024 12:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

christmas-review