-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify tests and remove uncessary config files everest/mathfunc #9434
Simplify tests and remove uncessary config files everest/mathfunc #9434
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a good direction! Removes a lot of duplication, and makes maintenance easier! I had a comment to one of the tests, we might be able to make some of the tests even more targeted.
e7ce1fa
to
fd02364
Compare
CodSpeed Performance ReportMerging #9434 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9434 +/- ##
==========================================
- Coverage 91.87% 91.85% -0.02%
==========================================
Files 433 433
Lines 26778 26788 +10
==========================================
+ Hits 24601 24607 +6
- Misses 2177 2181 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
574f2cf
to
006fcd4
Compare
Will squash commits after review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but I have one question you may need to resolve before merging?
0f2eab1
to
2f31e1c
Compare
Issue
Resolves #9210
Approach
Simplify tests and remove unnecessary config files in everest/math_func. Since (#9357) was a complete overkill will close that PR and work on this one.
For the life of me I am struggling to remove eitherconfig_remove_run_path
orconfig_fm_failure
since they are completely the same except thefail
argument. However, when I try to readconfig_remove_run_path
and replace theconfig.forward_model
with["toggle_failure --fail simulation_2"]
and set thelog_level
toinfo
the tests keeps failing and I don't understand why.NOTE: Test coverage should not have changed with this PR, only the number of config files that we check into our repository has been drastically reduced and some tests should be a bit more explicit in what they are testing.
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"'
)When applicable