Fix ForwardModels stuck in Running-state when event is lost #9432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9432 +/- ##
==========================================
+ Coverage 90.37% 91.86% +1.49%
==========================================
Files 349 433 +84
Lines 21894 26672 +4778
==========================================
+ Hits 19786 24503 +4717
- Misses 2108 2169 +61
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jonathan-eq
changed the title
jonathan-eq
changed the title
jonathan-eq
force-pushed
the
improve-snapshots
branch
3 times, most recently
from
b02a72a to
7be15cb
Compare
jonathan-eq
added
the
release-notes:bug-fix
jonathan-eq
force-pushed
the
improve-snapshots
branch
from
7be15cb to
ec62959
Compare
This commit makes snapshots overwrite non-finalized states for forwardmodels if the next forwardmodel has started. This will avoid forwardmodels being stuck in running/pending if an event is lost. This is a safe assumption as no forwardmodel will start running before the previous one has finished successfully.
jonathan-eq
force-pushed
the
improve-snapshots
branch
from
ec62959 to
3a1f4ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #9422
Approach
This commit in this PR makes snapshots overwrite non-finalized states for
forwardmodels if the next forwardmodel has started. This will avoid
forwardmodels being stuck in running/pending if an event is lost. This
is a safe assumption as no forwardmodel will start running before the
previous one has finished successfully.
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable