Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only set active realizations when restart is checked es_mda #9398

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

larsevj
Copy link
Contributor

@larsevj larsevj commented Nov 29, 2024

Issue
Resolves #9341

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@larsevj larsevj force-pushed the fix_active_reals_in_es_mda_panel branch from b53d3f9 to c5c47d5 Compare December 6, 2024 11:13
@larsevj larsevj added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Dec 6, 2024
@larsevj larsevj force-pushed the fix_active_reals_in_es_mda_panel branch from c5c47d5 to 1db0589 Compare December 6, 2024 11:19
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.83%. Comparing base (b903bb0) to head (95039c9).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9398      +/-   ##
==========================================
- Coverage   91.86%   91.83%   -0.04%     
==========================================
  Files         433      434       +1     
  Lines       26654    26740      +86     
==========================================
+ Hits        24486    24556      +70     
- Misses       2168     2184      +16     
Flag Coverage Δ
cli-tests 39.32% <0.00%> (-0.12%) ⬇️
everest-models-test 34.73% <0.00%> (-0.09%) ⬇️
gui-tests 72.16% <100.00%> (-0.23%) ⬇️
integration-test 36.99% <0.00%> (-0.09%) ⬇️
performance-tests 51.91% <0.00%> (-0.16%) ⬇️
test 40.68% <0.00%> (-0.08%) ⬇️
unit-tests 74.02% <80.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@larsevj larsevj mentioned this pull request Dec 6, 2024
9 tasks
Copy link
Contributor

@xjules xjules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR @larsevj ! 🚀
Don't forget to squash the commits.

@larsevj larsevj force-pushed the fix_active_reals_in_es_mda_panel branch from 68d203b to 95039c9 Compare December 9, 2024 12:20
@larsevj larsevj merged commit ea78bd8 into equinor:main Dec 9, 2024
39 checks passed
@larsevj larsevj deleted the fix_active_reals_in_es_mda_panel branch December 9, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Active realizations is set to zero for ES-MDA
3 participants