-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inline case_name variable #9254
Inline case_name variable #9254
Conversation
This fixes a regression from 2453a2c.
This solves a bug where find_unsmry() would not be able to locate the correct summary file even if it has the correct base for the Eclipse deck
This option is no longer available and is ignored by the application
https://github.com/equinor/ert/actions/runs/12006134015/job/33464079712?pr=9047 `FAILED tests/ert/unit_tests/gui/tools/plot/test_plot_api.py::test_plot_api_big_summary_memory_usage[1000-100-100-950] - assert 1301.3557224273682 < 950 `
Co-authored-by: Eivind Jahren <[email protected]>
Co-authored-by: Jonathan Karlsen <[email protected]>
Co-authored-by: Jonathan Karlsen <[email protected]>
ruff check --fix --unsafe-fixes
…/StephanDeHoop/ert_fork into inline_casename_variable_everest
I think I done something wrong here :")... Since it the smallest change in the world, resolving it in another PR (see #9594). |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9254 +/- ##
==========================================
+ Coverage 90.74% 91.85% +1.10%
==========================================
Files 352 433 +81
Lines 22043 26774 +4731
==========================================
+ Hits 20004 24594 +4590
- Misses 2039 2180 +141
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #9254 will degrade performances by 10.42%Comparing Summary
Benchmarks breakdown
|
Issue
Mistake when rebasing branch... Small (2 lines) change so made another PR.
Approach
See #9594
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"'
)When applicable