Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline case_name variable #9254

Closed

Conversation

StephanDeHoop
Copy link
Contributor

@StephanDeHoop StephanDeHoop commented Nov 19, 2024

Issue
Mistake when rebasing branch... Small (2 lines) change so made another PR.

Approach
See #9594

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@StephanDeHoop StephanDeHoop added release-notes:skip If there should be no mention of this in release notes everest labels Nov 19, 2024
oyvindeide and others added 28 commits November 21, 2024 09:05
This solves a bug where find_unsmry() would not be able to locate
the correct summary file even if it has the correct base for the
Eclipse deck
This option is no longer available
and is ignored by the application
https://github.com/equinor/ert/actions/runs/12006134015/job/33464079712?pr=9047
`FAILED tests/ert/unit_tests/gui/tools/plot/test_plot_api.py::test_plot_api_big_summary_memory_usage[1000-100-100-950] - assert 1301.3557224273682 < 950
`
verveerpj and others added 25 commits December 16, 2024 14:36
ruff check --fix --unsafe-fixes
@StephanDeHoop
Copy link
Contributor Author

StephanDeHoop commented Dec 19, 2024

I think I done something wrong here :")... Since it the smallest change in the world, resolving it in another PR (see #9594).

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 95.63107% with 99 lines in your changes missing coverage. Please review.

Project coverage is 91.85%. Comparing base (05b9e28) to head (7c41166).
Report is 259 commits behind head on main.

Files with missing lines Patch % Lines
src/ert/services/_storage_main.py 34.78% 15 Missing ⚠️
src/ert/scheduler/slurm_driver.py 78.43% 11 Missing ⚠️
src/ert/run_models/everest_run_model.py 94.81% 10 Missing ⚠️
src/ert/gui/simulation/run_dialog.py 88.33% 7 Missing ⚠️
...rc/ert/gui/simulation/ensemble_experiment_panel.py 28.57% 5 Missing ⚠️
.../tools/plot/customize/limits_customization_view.py 77.27% 5 Missing ⚠️
src/_ert/forward_model_runner/client.py 60.00% 4 Missing ⚠️
src/ert/__main__.py 76.47% 4 Missing ⚠️
src/ert/ensemble_evaluator/_ensemble.py 75.00% 4 Missing ⚠️
src/ert/gui/main.py 55.55% 4 Missing ⚠️
... and 19 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9254      +/-   ##
==========================================
+ Coverage   90.74%   91.85%   +1.10%     
==========================================
  Files         352      433      +81     
  Lines       22043    26774    +4731     
==========================================
+ Hits        20004    24594    +4590     
- Misses       2039     2180     +141     
Flag Coverage Δ
cli-tests 39.75% <48.98%> (+0.45%) ⬆️
everest-models-test 34.58% <46.29%> (?)
gui-tests 72.12% <69.99%> (+0.39%) ⬆️
integration-test 37.21% <47.13%> (?)
performance-tests 51.95% <66.41%> (+2.57%) ⬆️
test 40.46% <47.88%> (?)
unit-tests 74.18% <84.77%> (-5.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Dec 19, 2024

CodSpeed Performance Report

Merging #9254 will degrade performances by 10.42%

Comparing StephanDeHoop:inline_casename_variable_everest (7c41166) with main (2b41fe2)

Summary

❌ 1 regressions
✅ 21 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main StephanDeHoop:inline_casename_variable_everest Change
test_direct_dark_performance_with_storage[gen_x: 20, sum_x: 20 reals: 10-gen_data-get_record_observations] 1.5 ms 1.6 ms -10.42%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
everest release-notes:skip If there should be no mention of this in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.