-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give warning if runpath disk space is close to full on ert startup #9193
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9193 +/- ##
==========================================
+ Coverage 91.72% 91.76% +0.03%
==========================================
Files 430 431 +1
Lines 26639 26707 +68
==========================================
+ Hits 24435 24508 +73
+ Misses 2204 2199 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
e51449b
to
678f04d
Compare
initial attempt. Very open for suggestions regarding the text. |
4e76a62
to
da3bd16
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
Should this check be on startup or on experiment start? |
Might be better to be on experiment startup, seems like a lot of users ignore warnings on startup. Maybe we also should check space left on enspath? |
Yes, we should check there also, we have seen a lot of errors from missing capacity in enspath. Also, for enspath we could estimate how much space is necessary, but I suggest we keep that for another PR. |
I updated the description of the issue with a new approach to doing this. |
6d64523
to
642876f
Compare
642876f
to
33ffdb9
Compare
CodSpeed Performance ReportMerging #9193 will not alter performanceComparing Summary
|
cef3eaa
to
e6b01d1
Compare
c000806
to
47cac42
Compare
47cac42
to
9add58e
Compare
This seems ready to squash and merge now? |
Issue
Resolves #8921
The following is presented if disk is "close" to full:
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"'
)When applicable