Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give warning if runpath disk space is close to full on ert startup #9193

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

larsevj
Copy link
Contributor

@larsevj larsevj commented Nov 12, 2024

Issue
Resolves #8921

The following is presented if disk is "close" to full:
image

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 95.71429% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.76%. Comparing base (45a4b7c) to head (9add58e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ert/gui/simulation/view/disk_space_widget.py 94.44% 2 Missing ⚠️
src/ert/shared/status/utils.py 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9193      +/-   ##
==========================================
+ Coverage   91.72%   91.76%   +0.03%     
==========================================
  Files         430      431       +1     
  Lines       26639    26707      +68     
==========================================
+ Hits        24435    24508      +73     
+ Misses       2204     2199       -5     
Flag Coverage Δ
cli-tests 39.43% <27.14%> (-0.04%) ⬇️
everest-models-test 34.20% <27.14%> (-0.01%) ⬇️
gui-tests 71.92% <92.85%> (+0.09%) ⬆️
integration-test 38.32% <27.14%> (+0.02%) ⬆️
performance-tests 51.74% <67.14%> (+0.05%) ⬆️
test 39.61% <27.14%> (+<0.01%) ⬆️
unit-tests 74.05% <95.71%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@larsevj larsevj force-pushed the warn_on_full_disk branch 2 times, most recently from e51449b to 678f04d Compare November 12, 2024 13:30
@larsevj larsevj requested a review from berland November 12, 2024 13:31
@larsevj
Copy link
Contributor Author

larsevj commented Nov 12, 2024

initial attempt. Very open for suggestions regarding the text.

@larsevj
Copy link
Contributor Author

larsevj commented Nov 12, 2024

Second alternative:
image

Copy link
Contributor

@berland berland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@eivindjahren
Copy link
Contributor

Should this check be on startup or on experiment start?

@larsevj
Copy link
Contributor Author

larsevj commented Nov 15, 2024

Should this check be on startup or on experiment start?

Might be better to be on experiment startup, seems like a lot of users ignore warnings on startup. Maybe we also should check space left on enspath?

@eivindjahren
Copy link
Contributor

Should this check be on startup or on experiment start?

Might be better to be on experiment startup, seems like a lot of users ignore warnings on startup. Maybe we also should check space left on enspath?

Yes, we should check there also, we have seen a lot of errors from missing capacity in enspath. Also, for enspath we could estimate how much space is necessary, but I suggest we keep that for another PR.

@eivindjahren
Copy link
Contributor

I updated the description of the issue with a new approach to doing this.

@larsevj larsevj force-pushed the warn_on_full_disk branch from 642876f to 33ffdb9 Compare January 2, 2025 09:06
Copy link

codspeed-hq bot commented Jan 2, 2025

CodSpeed Performance Report

Merging #9193 will not alter performance

Comparing larsevj:warn_on_full_disk (9add58e) with main (9e2e32f)

Summary

✅ 24 untouched benchmarks

@larsevj larsevj force-pushed the warn_on_full_disk branch from cef3eaa to e6b01d1 Compare January 2, 2025 11:41
@larsevj
Copy link
Contributor Author

larsevj commented Jan 2, 2025

Currently:
image

@larsevj larsevj force-pushed the warn_on_full_disk branch 3 times, most recently from c000806 to 47cac42 Compare January 2, 2025 12:00
@eivindjahren
Copy link
Contributor

This seems ready to squash and merge now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider displaying the status of free disk spacefor runpath in the Ert gui
4 participants