Add new hook for specifying config per forward model step #9050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9050 +/- ##
==========================================
+ Coverage 90.72% 90.74% +0.02%
==========================================
Files 350 350
Lines 21783 21814 +31
==========================================
+ Hits 19763 19796 +33
+ Misses 2020 2018 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sondreso
reviewed
Oct 25, 2024
berland
force-pushed
the
fm_step_config_hook
branch
2 times, most recently
from
e8556b8 to
08c0a7c
Compare
berland
added
the
release-notes:new-feature
berland
force-pushed
the
fm_step_config_hook
branch
from
08c0a7c to
cfd7f15
Compare
berland
commented
Oct 30, 2024
berland
force-pushed
the
fm_step_config_hook
branch
from
3420067 to
3f6e3d8
Compare
berland
force-pushed
the
fm_step_config_hook
branch
2 times, most recently
from
5df682e to
3f4f80a
Compare
sondreso
reviewed
Nov 12, 2024
berland
force-pushed
the
fm_step_config_hook
branch
7 times, most recently
from
11961ab to
633fa2d
Compare
General configuration using key-values via the plugin system for individual steps will be merged with environment property of each ForwardModelStep that is dumped as json in every runpath.
berland
force-pushed
the
fm_step_config_hook
branch
from
633fa2d to
e3ec1e7
Compare
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #9036
Approach
➕
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable