Avoid redundant dataset loading #9016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yngve-sk
force-pushed
the
24.10.22-darkstorage-small-refactor-data-for-key
branch
from
3239656 to
08a0866
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9016 +/- ##
==========================================
+ Coverage 90.74% 90.76% +0.02%
==========================================
Files 352 352
Lines 21937 21978 +41
==========================================
+ Hits 19907 19949 +42
+ Misses 2030 2029 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yngve-sk
force-pushed
the
24.10.22-darkstorage-small-refactor-data-for-key
branch
2 times, most recently
from
ce1203e to
3d54e06
Compare
oyvindeide
reviewed
Oct 23, 2024
There was a problem hiding this comment.
Looks like a good change, I have some comments though, but a lot of them are nitpicks. Is: (squash) Add mutation of response keys to stateful storage test meant to be squashed into the first commit? If not I think that commit deserves a test. Suggest adding commits as --fixup so it is easier to tell which commit they are intended to be merged with.
yngve-sk
force-pushed
the
24.10.22-darkstorage-small-refactor-data-for-key
branch
5 times, most recently
from
458b278 to
35858cc
Compare
yngve-sk
force-pushed
the
24.10.22-darkstorage-small-refactor-data-for-key
branch
from
564a7b0 to
9423fbe
Compare
oyvindeide
reviewed
Oct 28, 2024
yngve-sk
force-pushed
the
24.10.22-darkstorage-small-refactor-data-for-key
branch
14 times, most recently
from
f0452e2 to
02ccc26
Compare
yngve-sk
force-pushed
the
24.10.22-darkstorage-small-refactor-data-for-key
branch
5 times, most recently
from
076373b to
4ff8cfe
Compare
oyvindeide
reviewed
Nov 13, 2024
.../ert/unit_tests/storage/snapshots/test_storage_migration/test_that_storage_matches/responses
Show resolved
Hide resolved
yngve-sk
force-pushed
the
24.10.22-darkstorage-small-refactor-data-for-key
branch
from
4ff8cfe to
3814647
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.