Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky warning test #8992

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Oct 18, 2024

cannot guarantee that there is no warning, but the test is specifically about ConfigWarning.

Resolves #8990

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

cannot guarantee that there is no warning, but
the test is specifically about ConfigWarning.
@eivindjahren eivindjahren added the release-notes:flaky-test-fix PR fixes a flaky test label Oct 18, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.55%. Comparing base (e5a183d) to head (3b992cd).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8992      +/-   ##
==========================================
+ Coverage   91.49%   91.55%   +0.06%     
==========================================
  Files         347      347              
  Lines       21397    21397              
==========================================
+ Hits        19577    19591      +14     
+ Misses       1820     1806      -14     
Flag Coverage Δ
cli-tests 39.61% <ø> (+0.20%) ⬆️
gui-tests 73.58% <ø> (+0.02%) ⬆️
performance-tests 50.19% <ø> (ø)
unit-tests 80.10% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andreas-el andreas-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏖️

@eivindjahren eivindjahren merged commit 9a06e99 into equinor:main Oct 18, 2024
56 checks passed
@eivindjahren eivindjahren deleted the fix_warning_test branch October 18, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:flaky-test-fix PR fixes a flaky test
Projects
None yet
3 participants