Improve validation for unintialized ensembles in manual update and evaluate ensemble #8980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8980 +/- ##
==========================================
- Coverage 91.54% 91.53% -0.01%
==========================================
Files 347 348 +1
Lines 21397 21433 +36
==========================================
+ Hits 19588 19619 +31
- Misses 1809 1814 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jonathan-eq
force-pushed
the
fix-bugs3
branch
from
9865892 to
683f3ee
Compare
jonathan-eq
added
the
release-notes:improvement
jonathan-eq
changed the title
jonathan-eq
force-pushed
the
fix-bugs3
branch
2 times, most recently
from
134593d to
ca70d8f
Compare
jonathan-eq
force-pushed
the
fix-bugs3
branch
from
ca70d8f to
24b160b
Compare
xjules
reviewed
Oct 17, 2024
|
|
||
| class RealizationsInEnsembleArgument(RangeStringArgument): | ||
| UNINITIALIZED_REALIZATIONS_SPECIFIED = ( | ||
| "The specified realization(s) %s are not found in selected ensemble." |
There was a problem hiding this comment.
Can we append the ensemble.name?; ie. "The specified realization(s) %s are not found in selected ensemble %s."?
xjules
reviewed
Oct 17, 2024
xjules
reviewed
Oct 17, 2024
| validation_status.setValue(token) | ||
| return validation_status | ||
|
|
||
| def _validate_selected_realization_exist(self, realization: int) -> bool: |
There was a problem hiding this comment.
Don't understand this one. Why we need to have responses when we are about to run evaluate experiment?
There was a problem hiding this comment.
^I meant to do parameters, not responses :)
jonathan-eq
force-pushed
the
fix-bugs3
branch
from
24b160b to
b029fee
Compare
xjules
reviewed
Oct 18, 2024
| attempted_realizations = rangestring_to_list(token) | ||
|
|
||
| invalid_realizations = [] | ||
| initialized_realization_ids = self.__ensemble.is_initalized() |
|
Can you squash the commits? |
experiment This commit adds validation for the realizations specified by the user when trying to run `manual_update` or `evaluate_experiment`. The validator checks the selected ensemble if the specified realization(s) exists. If not, the field becomes red and a warning is displayed. The commit also disables the realization field until an ensemble is selected.
jonathan-eq
force-pushed
the
fix-bugs3
branch
from
d966047 to
79e6917
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #8691
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
When specifying failed realizations:
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable