Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid possible UnboundLocalError for end_event #8945

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

berland
Copy link
Contributor

@berland berland commented Oct 11, 2024

The error has been observed to occur in the log. Not trying to display further error messages to why it is None.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

The error has been observed to occur in the log. Not trying
to display further error messages to why it is None.
@eivindjahren eivindjahren added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Oct 11, 2024
@berland berland enabled auto-merge (rebase) October 11, 2024 06:41
@berland berland merged commit 48745f6 into equinor:version-10.3 Oct 11, 2024
34 of 35 checks passed
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.81%. Comparing base (776174b) to head (f8a162f).
Report is 2 commits behind head on version-10.3.

Additional details and impacted files
@@              Coverage Diff              @@
##           version-10.3    #8945   +/-   ##
=============================================
  Coverage         90.81%   90.81%           
=============================================
  Files               342      342           
  Lines             20965    20966    +1     
=============================================
+ Hits              19039    19041    +2     
+ Misses             1926     1925    -1     
Flag Coverage Δ
gui-tests 75.63% <100.00%> (+<0.01%) ⬆️
integration-tests 53.77% <100.00%> (+<0.01%) ⬆️
unit-tests 68.77% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@berland berland deleted the ver103-endevent branch October 17, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants