Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use logger.exception for unexpected exceptions #8875

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Oct 4, 2024

Only use logger.exception for unexpected exceptions

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@eivindjahren eivindjahren added the release-notes:skip If there should be no mention of this in release notes label Oct 4, 2024
Copy link
Contributor

@andreas-el andreas-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes missing coverage. Please review.

Project coverage is 90.81%. Comparing base (e561119) to head (db2c2ba).

Files with missing lines Patch % Lines
src/ert/gui/tools/plot/plot_window.py 0.00% 5 Missing ⚠️
src/ert/__main__.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           version-10.3    #8875      +/-   ##
================================================
- Coverage         90.81%   90.81%   -0.01%     
================================================
  Files               342      342              
  Lines             20967    20965       -2     
================================================
- Hits              19041    19039       -2     
  Misses             1926     1926              
Flag Coverage Δ
gui-tests 75.63% <11.11%> (-0.01%) ⬇️
integration-tests 53.76% <11.11%> (-0.01%) ⬇️
unit-tests 68.78% <22.22%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eivindjahren eivindjahren merged commit 776174b into equinor:version-10.3 Oct 4, 2024
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants