Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid possible UnboundLocalError for end_event #8843

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

berland
Copy link
Contributor

@berland berland commented Oct 2, 2024

The error has been observed to occur in the log. Not trying to display further error messages to why it is None.

Issue
Resolves #my_issue

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@berland berland self-assigned this Oct 2, 2024
@berland berland added the release-notes:skip If there should be no mention of this in release notes label Oct 2, 2024
The error has been observed to occur in the log. Not trying
to display further error messages to why it is None.
@berland berland force-pushed the unbound_end_event branch from 33ea59e to ed3c27f Compare October 2, 2024 07:21
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.38%. Comparing base (4321e49) to head (ed3c27f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8843      +/-   ##
==========================================
- Coverage   91.40%   91.38%   -0.02%     
==========================================
  Files         342      342              
  Lines       21034    21035       +1     
==========================================
- Hits        19226    19223       -3     
- Misses       1808     1812       +4     
Flag Coverage Δ
cli-tests 39.61% <100.00%> (-0.02%) ⬇️
gui-tests 73.56% <100.00%> (+<0.01%) ⬆️
performance-tests 50.19% <100.00%> (-0.05%) ⬇️
unit-tests 79.84% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andreas-el andreas-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✈️

@berland berland merged commit 61c648a into equinor:main Oct 2, 2024
50 checks passed
@berland berland deleted the unbound_end_event branch October 9, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants